fix: set dataLabels.padding to 0 to avoid labels being cut off in pie charts
#1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
force-pushed
the
DHIS2-16505-pie-chart-labels-cut-off
branch
from
19ed77a
to
529ce32
Compare
martinkrulltott
approved these changes
Jun 12, 2024
|
Code approved. Needs thorough testing in both DV and Dashboards though before merging |
|
Closing this PR because the fix didn't work reliably. It just happened to fix the issue for a particular chart at a particular height. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16505
Relates to a yet-to-be-created PR in DV
Key features
Description
Setting the padding to zero fixes the reported issue.
As far as I am aware, there is no way of knowing exactly when the label is going to get cut off. As such this is an all-or-nothing type of solution: we set
paddingto0for all pie-charts, or we keep things the way they are.I have checked a few other pie-charts and vieports sizes and do not see any visual degaradations/changes due to this change, so I suggest we make this change.
Reproduction path
Test the fix
999.9.9-2024-06-12T15-12-27) with this fix includedScreenshots
Before
After