add jason's third submission attempt #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1lann
changed the title
|
Actually I found some more optimizations, so I updated it (four times), envvar instructions are the same though. |
1lann
force-pushed
the
submission-3
branch
2 times, most recently
from
e024bde
to
3b2d0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble predicting the performance on an M1 Mac because I don't have an M1 Mac. This program runs about 10% faster on Darwin x64, 20% faster on WSL on my x64 Desktop but about 15% faster on Oracle Cloud Linux ARM64 compared to my original solution.
If you have time, can I ask you also try to run it with the environment variable
BRCGO_ALT_MODE=1? If it runs consistently significantly slower (> 80ms) can you leave it unset (or set to "0"), otherwise I'd rather have it left on (i.e. if it looks to be very similar in performance with or without the environment variable, leave the environment variable set). I have this environment variable because I'm not sure if one of my "optimizations" I made hinders or improves performance on an M1 Mac.