Embed: Fix Incorrect URL basename logic in EmbedPreview (WordPress#63052

)


Co-authored-by: dhananjaykuber <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

packages/block-library/src/embed/embed-preview.js

@@ -20,6 +20,7 @@ import {
 } from '@wordpress/block-editor';
 import { Component } from '@wordpress/element';
 import { createBlock, getDefaultBlockName } from '@wordpress/blocks';
+import { getAuthority } from '@wordpress/url';
 
 /**
  * Internal dependencies
@@ -73,14 +74,11 @@ class EmbedPreview extends Component {
 		const { interactive } = this.state;
 
 		const html = 'photo' === type ? getPhotoHtml( preview ) : preview.html;
-		const parsedHost = new URL( url ).host.split( '.' );
-		const parsedHostBaseUrl = parsedHost
-			.splice( parsedHost.length - 2, parsedHost.length - 1 )
-			.join( '.' );
+		const embedSourceUrl = getAuthority( url );
 		const iframeTitle = sprintf(
 			// translators: %s: host providing embed content e.g: www.youtube.com
 			__( 'Embedded content from %s' ),
-			parsedHostBaseUrl
+			embedSourceUrl
 		);
 		const sandboxClassnames = clsx(
 			type,
@@ -136,7 +134,7 @@ class EmbedPreview extends Component {
 								__(
 									"Embedded content from %s can't be previewed in the editor."
 								),
-								parsedHostBaseUrl
+								embedSourceUrl
 							) }
 						</p>
 					</Placeholder>

test/e2e/specs/editor/various/embedding.spec.js

@@ -106,7 +106,7 @@ test.describe( 'Embedding content', () => {
 		await expect(
 			currenEmbedBlock.locator( 'iframe' ),
 			'Valid embed. Should render valid element.'
-		).toHaveAttribute( 'title', 'Embedded content from twitter' );
+		).toHaveAttribute( 'title', 'Embedded content from twitter.com' );
 
 		await embedUtils.insertEmbed(
 			'https://twitter.com/wooyaygutenberg123454312'
@@ -150,7 +150,7 @@ test.describe( 'Embedding content', () => {
 		await expect(
 			currenEmbedBlock.locator( 'iframe' ),
 			'Photo content. Should render valid iframe element.'
-		).toHaveAttribute( 'title', 'Embedded content from cloudup' );
+		).toHaveAttribute( 'title', 'Embedded content from cloudup.com' );
 	} );
 
 	test( 'should allow the user to convert unembeddable URLs to a paragraph with a link in it', async ( {