fix memory leak on incor calc of cleanup bucket #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
previously approved these changes
Dec 26, 2024
flymedllva
force-pushed
the
fix-memory-leak-on-incor-calc-of-cleanup-bucket
branch
from
0507668 to
4b34a22
Compare
|
@flymedllva Thank you for the PR. The ci passes. is it possible to write a test for the issue? |
cleanup does not try to clean empty bucket
flymedllva
force-pushed
the
fix-memory-leak-on-incor-calc-of-cleanup-bucket
branch
from
c61ba03 to
89d19c9
Compare
|
I couldn't find a direct test for cleanup, so I made one and included in its implementation a sub-check that caused the slice to grow uncontrollably without allowing cleanup to terminate. With the fix, this test passes. |
flymedllva
force-pushed
the
fix-memory-leak-on-incor-calc-of-cleanup-bucket
branch
from
89d19c9 to
dc92bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup now does not try to clean an empty bucket selected by the cleanup algorithm
this fixes a critical problem of slice growth when the algorithm incorrectly calculates the buckets that need to be cleared, let's say this behavior occurs at the time change described in issue: #426
this problem appeared after improving cleanup in this pr: #358
most likely the algorithm for calculating the cleaning bins also needs to be revised, but for me now it is important to fix the increase in memory consumption when changing the system time