Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using defer m.Unlock in store.go #425

Merged
merged 2 commits into from
Dec 17, 2024
Merged

refactor: using defer m.Unlock in store.go #425

merged 2 commits into from
Dec 17, 2024

Conversation

hoo47
Copy link
Contributor

@hoo47 hoo47 commented Dec 17, 2024 •
edited
Loading

  • AS-IS: calls m.Unlock() before the end of function(method)
  • TO-BE: using defer keyword, automatically calling unlock method right before return statements

@hoo47 hoo47 requested a review from a team as a code owner December 17, 2024 05:59
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mangalaman93
mangalaman93 requested changes Dec 17, 2024
View reviewed changes
store.go Show resolved Hide resolved
@mangalaman93 mangalaman93 enabled auto-merge (squash) December 17, 2024 07:15
@mangalaman93 mangalaman93 merged commit f9e778b into dgraph-io:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoo47 @CLAassistant @mangalaman93