-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation for directive arguments inside Type Definition #4
base: master
Are you sure you want to change the base?
Conversation
Added a function that translates map[string]interface{} to ast.Value
Add validation for directive location. A directive can not be used at any location. It must be used only at location on which it has been defined for.
59e59a8
to
6b4a785
Compare
@minhaj-shakeel Hi! I've started maintaining vektah/gqlparser and I would love to merge your improvements upstream. I know you are all dealing with quite a bit, but if I can help in any way, please don't hesitate to let me know. |
Hello again! I would love to help merge the improvements in this fork into the upstream version. I would really appreciate it if you can open PRs there if you get a chance. I made a draft mega-giant-one just to remember what all the DGraph changes were: vektah#179 People who contributed to that are: |
|
hey, is that PR dead ? |
Fixes GRAPHQL-671.
This PR adds argument validation in the directive validation applied to the fields inside a given type.
For example earlier
didn't return error while validation of type but now it does.