Skip to content

Commit

Permalink
Bumps netlify-cli to the current latest version (17.33.5).
Browse files Browse the repository at this point in the history
This actually broke deployments because of [this commit](netlify/cli@f684887) which seems to resolve things based on the CWD instead of the "root" (resolves to `.../execroot/rules_prerender`). We actually would probably prefer the CWD here since that would allow `rootpath` over `execroot` which is better because `@aspect_rules_js` tries copies everything into a single directory.

However the `netlify.toml` config file is not picked up under `--dir` and there does not appear to be an option to provide it explicitly. The easier approach is to `chdir` into the root-relative path (under runfiles) and deploy from there.

Unfortunately the transitive `unix-dgram` dependency does not appear to have been removed or updated, so the pnpm package extension still seems to be required.
  • Loading branch information
dgp1130 committed Aug 4, 2024
1 parent c0d8967 commit 1f9f4c4
Show file tree
Hide file tree
Showing 3 changed files with 2,076 additions and 1,716 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"jasmine": "4.3.0",
"marked": "^8.0.0",
"nan": "^2.17.0",
"netlify-cli": "^16.1.0",
"netlify-cli": "^17.33.5",
"node-fetch": "^3.2.5",
"node-gyp": "^9.4.0",
"preact": "^10.13.1",
Expand Down
Loading

0 comments on commit 1f9f4c4

Please sign in to comment.