-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from sparklemotion:main #3
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
15 similar comments
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
[skip ci]
- xmlGetActualEncoding is an internal-only libxml2 function which we can't use (yet?) - the ctxt->input->encoding bit is no longer needed as of libxml 2.12 [skip ci]
**What problem is this PR intended to solve?** I'm about to do some work on the sax parser encoding functionality, so let's clean this file up.
"it's" means "it is", "its" means "belonging to it"
We'll use this in an upcoming commit to simplify the sax parsers
and polyfill xmlSwitchEncodingName. We'll need this functionality in the next commit.
Previously, encoding overrides were not implemented for XML::SAX::Parser#parse_memory (as reported in #918) and XML::SAX::Parser#parse_file. However, this commit goes further and significantly simplifies and unifies the two SAX::ParserContext implementations and the two SAX::Parser implementations. This commit also allows Encoding objects and encoding names to be passed into the SAX::ParserContext methods, and the XML memory and file methods now accept and properly use passed encodings. Finally, this commit also backfills a lot of test coverage for the XML and the HTML4 sax parser encoding. Closes #918
**What problem is this PR intended to solve?** Previously, encoding overrides were not implemented for XML::SAX::Parser#parse_memory (as reported in #918) and XML::SAX::Parser#parse_file. However, this commit goes further and significantly simplifies and unifies the two SAX::ParserContext implementations and the two SAX::Parser implementations. This commit also allows Encoding objects and encoding names to be passed into the SAX::ParserContext methods, and the XML memory and file methods now accept and properly use passed encodings. Finally, this commit also backfills a lot of test coverage for the XML and the HTML4 sax parser encoding. Closes #918 **Have you included adequate test coverage?** Yes. **Does this change affect the behavior of either the C or the Java implementations?** Yes, but they are more consistent with each other.
Updates the requirements on [standard](https://github.com/standardrb/standard) to permit the latest version. - [Release notes](https://github.com/standardrb/standard/releases) - [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md) - [Commits](standardrb/standard@v1.39.0...v1.39.1) --- updated-dependencies: - dependency-name: standard dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
and replace the .cross_rubies file with misc/native.yml
**What problem is this PR intended to solve?** Update to rake-compiler-dock v1.9.1 and replace the .cross_rubies file with misc/native.yml
[skip ci]
**What problem is this PR intended to solve?** Improvements to doc for XML::ParseOptions. **Have you included adequate test coverage?** N/A. All doc. **Does this change affect the behavior of either the C or the Java implementations?** No. --------- Co-authored-by: Mike Dalessio <[email protected]>
**What problem is this PR intended to solve?** Clarifies the far-reaching importance of XML::Node. **Have you included adequate test coverage?** Doc only. **Does this change affect the behavior of either the C or the Java implementations?** Doc only.
[skip ci]
Updates the requirements on [standard](https://github.com/standardrb/standard) to permit the latest version. - [Release notes](https://github.com/standardrb/standard/releases) - [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md) - [Commits](standardrb/standard@v1.44.0...v1.45.0) --- updated-dependencies: - dependency-name: standard dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
and some other small fixes
[skip ci]
I had thought to put in an Issue for this, but instead will make bold and propose to `:nodoc:` `Node#accept`. Reason: I was unable to find out how I would use this (so maybe it should be internal?). I found nothing in `test`, and on the wide web, saw only that accept/visit often have to do with data locking. If this is to be retained as user documentation, I'd like to be able to document it properly, but would need help (pointers to relevant docs both within `nokogiri` and elsewhere).
**What problem is this PR intended to solve?** Forward-port #3437 to `main`.
…3447) Implements part of [Issue 3439](#3439). --------- Co-authored-by: Mike Dalessio <[email protected]>
**What problem is this PR intended to solve?** In this PR, I've updated `Node#namespace_definitions` to no longer use the namespace cache, meaning it uses the attributes defined on the node to determine the return value(s). Removing this use of the cache revealed a separate bug in the `relink_namespace` java function, which suddenly became better tested on JRuby as a result of removing the cache usage (which was hiding the bug). Finally, removing the cache also means that `relink_namespace` now needs to remove namespace definitions that are redundant (that is, the exact prefix and URI resolve in the parent) in order to match the CRuby implementation, so I've done that, too. Closes #2543 **Have you included adequate test coverage?** Yes. **Does this change affect the behavior of either the C or the Java implementations?** Only the Java implementation, which now behaves like the CRuby implementation (and I've resolved a pending JRuby test).
so that pending_if displays the right frame
so that nodes can be built that rely on namespaces they define. Fixes #3458
**What problem is this PR intended to solve?** Simplify Builder to do late binding on namespaces, so that nodes can be built that rely on namespaces they define. Fixes #3458 **Have you included adequate test coverage?** Existing pending coverage (now resolved) is sufficient. **Does this change affect the behavior of either the C or the Java implementations?** This really only affects the CRuby implementation, which now behaves like the JRuby impl does.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )