Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB uses OrderedDict for parameters and work with numeric fluents (functions). #21

Merged
merged 5 commits into from
May 8, 2021

Conversation

dgerod
Copy link
Owner

@dgerod dgerod commented Mar 14, 2021

No description provided.

… done by plan() function, so this function should not exists.
…oals are set using kwargs. Due to a bug of ROSPlan the parameters should be passed as OrderedDict.

For example, instead of doing this:
  kb.add_goal('object-at', o='item_3', p='b1')
it should be done like:
  kb.add_goal('object-at', OrderedDict([("o", 'item_3'), ("p", "b1")]))
@dgerod
Copy link
Owner Author

dgerod commented Mar 14, 2021

Main contributions:

  • Make mandatory to use OrderedDict in parameters of KB(*). This is due to this issue 255 in ROSPlan. This issues is happening when using Python 2 but not in Python 3, in Python 3 **kwargs use OrderedDict by default.
  • Add functionality to KB to work with numeric fluents (functions).

(*) An example of passing argument to KB. Instead of doing this:
kb.add_goal('object-at', o='item_3', p='b1')
it should be done like:
kb.add_goal('object-at', OrderedDict([("o", 'item_3'), ("p", "b1")]))

@dgerod dgerod changed the title v2/develop KB uses OrderedDict for parameters and work with numeric fluents (functions). Mar 14, 2021
@dgerod dgerod merged commit 51aa609 into master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant