Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api v2 update asset #709

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Api v2 update asset #709

merged 10 commits into from
Feb 4, 2025

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Feb 4, 2025

This is the implementation of endpoint PUT /api/v2/cases/{case_identifier}/assets/{identifier}, to update assets.
Here are the task performed within this PR:

  • implementation PUT /api/v2/cases/{case_identifier}/assets/{identifier} and tests
  • added a method for update in the business layer
  • deprecated POST /case/assets/update/{cur_id}
  • quality: rename case_id into case_identifier in app/blueprints/rest/v2/cases/assets.py (avoid abbreviations)
  • quality: activate ruff rule F403
  • quality: activate ruff rule F541 and fix reported warnings for this rule

Note: this PR goes hand in hand with iris-doc-src PR#39

@c8y3 c8y3 requested a review from whikernel February 4, 2025 09:58
@c8y3 c8y3 linked an issue Feb 4, 2025 that may be closed by this pull request
Api v2 asset update #706
Open
6 tasks
@whikernel whikernel merged commit cb22d19 into develop Feb 4, 2025
18 checks passed
@whikernel whikernel deleted the api_v2_update_asset branch February 4, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whikernel whikernel whikernel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api v2 asset update
2 participants
@c8y3 @whikernel