Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api v2 update task #698

Merged
merged 64 commits into from
Jan 24, 2025
Merged

Api v2 update task #698

merged 64 commits into from
Jan 24, 2025

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Jan 24, 2025

This PR add endpoint PUT /api/v2/cases/{case_identifier}/tasks/{identifier} to update a case. Here are the things changed in this PR:

  • added endpoint PUT /api/v2/cases/{case_identifier}/tasks/{identifier} in app.blueprints.rest.v2.cases.tasks
  • tests: added associated tests
  • deprecated endpoint POST /case/tasks/update/int:cur_id
  • simplification: have method tasks_update expect a CaseTasks object instead of an identifier in app.business.tasks (the get_task is done before)
  • simplification: app.blueprints.pages.case.case_tasks_routes.py extracted method get_task_assignees from method get_task_with_assignees, removed the more complicated method get_task_with_assignees
  • quality: split ruff check in its own job, so that we get the result faster
  • quality: removed all unused imports
  • quality: removed indirect imports in app.models.init
  • quality: activated rule F401 (unused imports)
  • quality: replaced case_id by case_identifier in app.blueprints.rest.v2.cases.iocs
  • quality: using string interpolation rather than string concatenation in ui/src/pages/case.tasks.js

c8y3 added 30 commits January 24, 2025 08:33
…PUT /api/v2/cases/<int:case_identifier>/tasks/<int:identifier>
@c8y3 c8y3 requested a review from whikernel January 24, 2025 09:18
@c8y3 c8y3 linked an issue Jan 24, 2025 that may be closed by this pull request
4 tasks
@whikernel whikernel merged commit e1911d9 into develop Jan 24, 2025
8 checks passed
@c8y3 c8y3 deleted the api_v2_update_task branch January 29, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API v2 task update
2 participants