feat: Make integration #4083
Open
feat: Make integration #4083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild-only-necessary
|
After fixing some bugs, I successfully deployed my site in production using my modified DFX. |
|
Please, review this PR for its merge, because I tested its last version hundreds of time in a real scenario. It is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--no-compiletodeployandgenerateand--no-deps(don't compile dependencies) tobuild.rulesthat outputs GNU Make rules.Then rules can be used:
build@NAME- compile a canister.deploy@NAME- deploy a canister.generate@NAME- generate bindings for a canister.Implementation note: I added argument
no_depsto many functions. This is a non-elegant code and I am asking you to advise me what can be done.How Has This Been Tested?
I ran it literally at least hundreds (or thousands) of times in practical uses of my software. It does work well.
Checklist: