Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add browser warning message #4048

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add browser warning message #4048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73663e3
Add message for safari users
adamspofford-dfinity Dec 20, 2024
1753c37
changeloig
adamspofford-dfinity Dec 20, 2024
9b13781
Update message
adamspofford-dfinity Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

# UNRELEASED

### fix: template frontends now have unsupported browser warnings

DFX's default security headers cause Safari to break when viewing local canisters. Warning messages
have been added to the frontend project templates when the page is broken that indicate to try switching
browsers.

### fix: `dfx deploy --by-proposal` no longer sends chunk data in ProposeCommitBatch

Recently we made `dfx deploy` include some chunk data in CommitBatch, in order to streamline
Expand Down
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/react/src/__frontend_name__/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
</head>

<body>
<div class="browser-warning">
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
Firefox are recommended.
</div>
<div id="root"></div>
<script type="module" src="/src/main.jsx"></script>
</body>
Expand Down
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/react/src/__frontend_name__/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ button[type="submit"] {
#greeting:empty {
display: none;
}

.browser-warning {
display: none;
}
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/svelte/src/__frontend_name__/src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
</head>

<body data-sveltekit-preload-data="hover">
<div class="browser-warning">
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
Firefox are recommended.
</div>
<div style="display: contents">%sveltekit.body%</div>
</body>

Expand Down
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/svelte/src/__frontend_name__/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ button[type="submit"] {
#greeting:empty {
display: none;
}

.browser-warning {
display: none;
}
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
</head>

<body>
<div class="browser-warning">
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
Firefox are recommended.
</div>
<div id="root"></div>
<script type="module" src="/src/main.js"></script>
</body>
Expand Down
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ button[type="submit"] {
#greeting:empty {
display: none;
}

.browser-warning {
display: none;
}
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/vue/src/__frontend_name__/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
<strong>We're sorry but this application doesn't work properly without
JavaScript enabled. Please enable it to continue.</strong>
</noscript>
<div class="browser-warning">
⚠️ If this page appears broken, try reloading. If the problem persists, try switching browsers; Chrome or
Firefox are recommended.
</div>
<div id="app"></div>
<script src="/src/main.js" type="module"></script>
</body>
Expand Down
4 changes: 4 additions & 0 deletions src/dfx/assets/project_templates/vue/src/__frontend_name__/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ button[type="submit"] {
#greeting:empty {
display: none;
}

.browser-warning {
display: none;
}
Loading