-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update frontend templates #4003
base: master
Are you sure you want to change the base?
Conversation
src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/assets/.ic-assets.json5
Outdated
Show resolved
Hide resolved
src/dfx/assets/project_templates/vue/src/__frontend_name__/public/.ic-assets.json5
Outdated
Show resolved
Hide resolved
// Once you improved the headers for your dapp, set the security policy to "hardened" to disable the warning. | ||
// Options are: "hardened" | "standard" | "disabled". | ||
"security_policy": "standard", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the remaining changes to these .ic-asset.json files are whitespace-only: changing the indentation, and removing some newlines (newlines that improved readability). Can we make it so this PR doesn't change these files at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "standard" policy does not work on safari. I've added an identical CSP to each project currently works on Safari, but that should be updated at a later date when dfx can do the handling of CSP between dev / prod modes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I create a new project using the SvelteKit frontend and load using a URL like http://127.0.0.1:4943/?canisterId=bd3sg-teaaa-aaaaa-qaaba-cai, I see the expected page:
However, when I type a name and press the button:
When using a URL like http://bd3sg-teaaa-aaaaa-qaaba-cai.localhost:4943/, the CSS does still work, but the name doesn't show up after "Click Me!"
Description
This PR updates the frontend templates to a design provided by the design team, updates the default CSP so that hello world projects are operational on Safari locally, and updates dependencies on Sass to remove deprecation warnings.
Resolves: