Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update frontend templates #4003

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2024

Description

This PR updates the frontend templates to a design provided by the design team, updates the default CSP so that hello world projects are operational on Safari locally, and updates dependencies on Sass to remove deprecation warnings.

Resolves:

@ghost ghost self-requested a review as a code owner November 18, 2024 19:06
@ghost ghost requested a review from ericswanson-dfinity December 5, 2024 16:34
@ghost ghost enabled auto-merge (squash) December 5, 2024 17:06
@ghost ghost requested review from lwshang and krpeacock December 10, 2024 14:19
@ghost ghost requested a review from ericswanson-dfinity December 12, 2024 17:03
// Once you improved the headers for your dapp, set the security policy to "hardened" to disable the warning.
// Options are: "hardened" | "standard" | "disabled".
"security_policy": "standard",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the remaining changes to these .ic-asset.json files are whitespace-only: changing the indentation, and removing some newlines (newlines that improved readability). Can we make it so this PR doesn't change these files at all?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "standard" policy does not work on safari. I've added an identical CSP to each project currently works on Safari, but that should be updated at a later date when dfx can do the handling of CSP between dev / prod modes

Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a new project using the SvelteKit frontend and load using a URL like http://127.0.0.1:4943/?canisterId=bd3sg-teaaa-aaaaa-qaaba-cai, I see the expected page:

Screenshot 2024-12-13 at 8 11 58 AM

However, when I type a name and press the button:
Screenshot 2024-12-13 at 8 12 13 AM

When using a URL like http://bd3sg-teaaa-aaaaa-qaaba-cai.localhost:4943/, the CSS does still work, but the name doesn't show up after "Click Me!"

@ghost ghost requested a review from ericswanson-dfinity December 18, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant