feat: DfxInterfaceBuilder can provide extension manager #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so extension commands can load dfx.json if it references a canister with a type defined by an extension. See https://dfinity.atlassian.net/browse/SDK-1832
adamspofford-dfinity
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DfxInterfaceBuilder::buildloads dfx.json. If dfx.json has a canister with a type defined by an extension, then it's necessary to provide an ExtensionManager, otherwise the loader won't recognize the canister'stype.This adds methods to DfxInterfaceBuilder, as well as a standalone method for extracting the dfx version from the dfx cache path.
Required for https://dfinity.atlassian.net/browse/SDK-1832
How Has This Been Tested?
Tested in dfinity/dfx-extensions#153
Checklist: