Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message when local replica not running #3973

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Nov 5, 2024

Description

The current error message for a non-running local replica is not great:

Error: Failed while waiting for agent status.
Caused by: An error happened during communication with the replica: error sending request for url (http://127.0.0.1:4943/api/v2/status)
Caused by: error sending request for url (http://127.0.0.1:4943/api/v2/status)
Caused by: client error (Connect)
Caused by: tcp connect error: Connection refused (os error 61)
Caused by: Connection refused (os error 61)

This PR adds a nice message explaining in understandable words what the problem is and what to do.

How Has This Been Tested?

added e2e, some manual testing

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner November 5, 2024 13:09
@sesi200 sesi200 merged commit a4ca210 into master Nov 5, 2024
298 checks passed
@sesi200 sesi200 deleted the severin/local-replica-not-running-error branch November 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants