Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DFX sometimes omits a canister in .env #3834

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: DFX sometimes omits a canister in .env #3834

wants to merge 4 commits into from

Conversation

vporton
Copy link
Contributor

@vporton vporton commented Jul 15, 2024

Description

I changed the code and it now seems to work. However, this is unchecked and probably illogical code.

However, testing with the repository specified in #3833 does work. It creates .env file with CANISTER_ID_REPOSITORYINDEX variable as expected by both dfx deploy RepositoryIndex and dfx deploy test commands.

Probably, fixes #3833

How Has This Been Tested?

See above.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vporton vporton requested a review from a team as a code owner July 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DFX sometimes omits a canister in .env
1 participant
@vporton