fix: for dfx new failure if node is installed but npm is not #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would fail with "Failed to scaffold frontend code" Also, now checks the status code when calling node and npm to see if they are installed. This means if there is a script that outputs something like the below, dfx will no longer assume the program is installed. $ npm Command 'npm' not found, but can be installed with: apt install npm Please ask your administrator.
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
lwshang
reviewed
Apr 23, 2024
| assert_command dfx new e2e_project1 --type motoko --frontend sveltekit | ||
| assert_contains "Node could not be found. Skipping installing the frontend example code." | ||
| assert_contains "npm could not be found. Skipping installing the frontend example code." | ||
| assert_contains "You can bypass this check by using the --frontend flag." |
There was a problem hiding this comment.
The executed command has the --frontend flag.
IIUC, this line "You can bypass this check by using the --frontend flag." cannot be true.
The instruction might be outdated after the big dfx new rewrite.
There was a problem hiding this comment.
I agree, but adjacent work in the context of this PR
There was a problem hiding this comment.
lwshang
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx newwould fail with "Failed to scaffold frontend code" if node was installed, but npm was not installed.Also, now checks the status code when calling node and npm to see if they are installed. This means if there is a script that outputs something like the below, dfx will no longer assume the program is installed.
How Has This Been Tested?
Added an e2e test
Checklist: