Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: can install large wasm with non-empty chunk store #3706

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Apr 11, 2024

Description

We got a few reports of canister installation failure in this forum thread.

The issue was already fixed by a recent agent-rs upgrade. Explained in my forum response.

In this PR, I added an e2e test to make sure that we fixed the real issue.
It consists of three commits.

Commit 1

Add the e2e test

Commit 2

Changed the agent-rs dependency to the previous version to reveal the issue.

The error was reproduced here: https://github.com/dfinity/sdk/actions/runs/8640870988/job/23690258660#step:10:136

# Installing code for canister large, with canister ID bkyz2-fmaaa-aaaaa-qaaaq-cai
# Error: Failed to install wasm module to canister 'large'.
# Caused by: Failed to install wasm module to canister 'large'.
#   Failed during wasm installation call: Candid returned an error: input: 4449444c036d016c01cedfa0a804026d7b010001_20a12871fee210fb8619291eaea194581cbd2531e4b23759d225f6806923f63222
# table: type table0 = vec table1
# type table1 = record { 1_158_164_430 : table2 }
# type table2 = vec nat8
# wire_type: record { 1_158_164_430 : table2 }, expect_type: unknown

Commit 3

Got back the fixed agent-rs. Then the new e2e test passed.

How Has This Been Tested?

e2e test in install.bash.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review April 11, 2024 13:10
@lwshang lwshang requested review from chenyan-dfinity and a team as code owners April 11, 2024 13:10
@lwshang lwshang merged commit d09a45a into master Apr 11, 2024
179 checks passed
@lwshang lwshang deleted the lwshang/test_install_with_non_empty_chunk_store branch April 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants