Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set CANISTER_CANDID_PATH_ properly for remote canisters #3701

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Apr 9, 2024

Description

In the remote canister declaration it is possible to set a candid file to use when the canister is remote on a specific network. This candid file is not properly reported in the build step's environment variables when building on a remote network.

How Has This Been Tested?

added e2e

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review April 10, 2024 08:01
@sesi200 sesi200 requested review from chenyan-dfinity and a team as code owners April 10, 2024 08:01
e2e/tests-dfx/remote.bash Outdated Show resolved Hide resolved
@sesi200 sesi200 merged commit bbf9e9f into master Apr 16, 2024
179 checks passed
@sesi200 sesi200 deleted the severin/remote-candid-path branch April 16, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants