feat(beta): enable cycles ledger support #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
commented
Mar 21, 2024
| pkill -P $MITMDUMP_PID | ||
| kill $MITMDUMP_PID | ||
| pkill -P "$MITMDUMP_PID" | ||
| kill "$MITMDUMP_PID" |
There was a problem hiding this comment.
Requested by latest shellcheck version
ericswanson-dfinity
approved these changes
Mar 21, 2024
THLO
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the environment variable
DFX_CYCLES_LEDGER_SUPPORT_ENABLEis set and no cycles wallet is configured, then dfx will try to use the cycles ledger to perform any operation that the cycles wallet usually is used for.The following commands/options have been unhidden:
dfx cycles--from-subaccountfordfx deploy,dfx canister create,dfx canister deposit-cyclesto determine which cycles ledger subaccount the used cycles should be used from--created-at-timefordfx deploy,dfx create canister,dfx canister deposit-cyclesto control transaction deduplication on the cycles ledger--to-subaccountfordfx canister deleteto control into which subaccount cycles are withdrawn before the canister is deletedThe cycles ledger will not be supported by default until the cycles ledger canister is under NNS control.
Fixes SDK-1331
How Has This Been Tested?
e2e
Checklist: