Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shellcheck warnings in install script #3468

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: shellcheck warnings in install script #3468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions public/install/999_footer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ download_and_install() {
ensure downloader "$_sha256_url" "${_sha256_filename}"

log "Checking integrity of tarball..."
ensure $SHASUM -c "${_sha256_filename}"
ensure "$SHASUM" -c "${_sha256_filename}"

ensure tar -xzf "${_tarball_filename}"
ensure cd "${_archive}" >/dev/null
Expand Down Expand Up @@ -73,10 +73,9 @@ main() {
need_cmd touch

local _dir
_dir="$(mktemp -d 2>/dev/null)"
if [ $? -ne 0 ]; then
_dir="$(mktemp -d -t dfinity-dfxvm)"
if [ $? -ne 0 ]; then

if ! _dir="$(mktemp -d 2>/dev/null)"; then
if ! _dir="$(mktemp -d -t dfinity-dfxvm)"; then
err "failed to create temporary directory"
fi
fi
Expand Down
Loading