Skip to content

Commit

Permalink
Do not set NODE_ENV
Browse files Browse the repository at this point in the history
  • Loading branch information
fxgst committed Nov 20, 2024
1 parent a5e8144 commit 5e5ef23
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

# UNRELEASED

### chore: `dfx deploy --ic` does not set `NODE_ENV` to `production` anymore

# 0.24.3

### feat: Bitcoin support in PocketIC
Expand Down
5 changes: 0 additions & 5 deletions src/dfx/src/lib/builders/assets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use anyhow::{anyhow, Context};
use candid::Principal as CanisterId;
use console::style;
use dfx_core::config::cache::Cache;
use dfx_core::config::model::network_descriptor::NetworkDescriptor;
use fn_error_context::context;
use slog::{o, Logger};
use std::fs;
Expand Down Expand Up @@ -214,10 +213,6 @@ fn build_frontend(
cmd.arg("--workspace").arg(workspace);
}

if NetworkDescriptor::is_ic(network_name, &vec![]) {
cmd.env("NODE_ENV", "production");
}

for (var, value) in vars {
cmd.env(var.as_ref(), value);
}
Expand Down

0 comments on commit 5e5ef23

Please sign in to comment.