Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_team_name #126

Merged
merged 19 commits into from
May 9, 2023
2 changes: 1 addition & 1 deletion .github/custom_python_actions/compliance_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def get_team_name(code_owners: str, org_name: str) -> str:
if len(team_handle) > 1:
raise Exception("Only one team can be listed for repo-level codeowners.")
codeowner_team = team_handle[0].lower()
team_name = codeowner_team.strip(f"@{org_name.lower()}").strip("/")
team_name = codeowner_team.replace(f"@{org_name.lower()}/", "")
cgundy marked this conversation as resolved.
Show resolved Hide resolved
return team_name


Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python_lint_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ name: Python Workflow
on:
pull_request:
paths:
- custom_python_actions/**
- tests/**
- .github/custom_python_actions/**
- .github/tests/**
merge_group:
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ ic
sdk
```

To unlock a repository, you should create a [Pull Request](https://github.com/dfinity/repositories-open-to-contributions/compare) where you add the name in alphabetical order.
To unlock a repository, you should create a [Pull Request](https://github.com/dfinity/repositories-open-to-contributions/compare) where you add the name in alphabetical order. Be sure to commit this directly to the repository, a PR from a forked repository will not work.
cgundy marked this conversation as resolved.
Show resolved Hide resolved