Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solidity to nav bar #2410

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add Solidity to nav bar #2410

merged 1 commit into from
Jan 30, 2024

Conversation

jessiemongeon1
Copy link
Collaborator

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner January 29, 2024 21:25
ghost
ghost approved these changes Jan 29, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're reaching the maximum number of programming languages we should display horizontally on the nav. Should we consider making this a dropdown at some point?

@jessiemongeon1
Copy link
Collaborator Author

I think we're reaching the maximum number of programming languages we should display horizontally on the nav. Should we consider making this a dropdown at some point?

Yes, if we were to add more in the future, it would need to transition to a drop down I think.

@jessiemongeon1 jessiemongeon1 merged commit 432f54d into master Jan 30, 2024
4 checks passed
@jessiemongeon1 jessiemongeon1 deleted the add-solidity-sidebar branch January 30, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jessiemongeon1