Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update showcase.json #2335

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Update showcase.json #2335

merged 5 commits into from
Jan 12, 2024

Conversation

jdchibuk
Copy link
Contributor

@jdchibuk jdchibuk commented Jan 9, 2024

re: "user controlled mind and body canister”

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

re: "user controlled mind and body canister”
@jdchibuk jdchibuk requested a review from a team as a code owner January 9, 2024 16:46
@sa-github-api
Copy link

Dear @jdchibuk,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

Copy link
Contributor

@jennifertrin jennifertrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also review the CLA steps?

@jdchibuk
Copy link
Contributor Author

should be updated for format now

here is CLA confirmation: dfinity/cla#424 (comment)

@jennifertrin
Copy link
Contributor

should be updated for format now

here is CLA confirmation: dfinity/cla#424 (comment)

Thank you. Can you add a file to the repo instead of calling a link for the logo?

@jdchibuk
Copy link
Contributor Author

got it - added to img/showcase/ folder - let me know if this works - appreciate the help!

@jennifertrin
Copy link
Contributor

should be updated for format now

here is CLA confirmation: dfinity/cla#424 (comment)

got it - added to img/showcase/ folder - let me know if this works - appreciate the help!

Yes, this works! Thank you!

@jennifertrin jennifertrin merged commit bf7c42b into dfinity:master Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants