-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about critical proposal types and MintSnsTokens #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaraAS
reviewed
Jan 11, 2024
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lara Schmid <[email protected]>
Co-authored-by: Lara Schmid <[email protected]>
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Jan 11, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
LaraAS
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more small things, but otherwise LGTM.
Thanks for writing this and updating it today!
Co-authored-by: Lara Schmid <[email protected]>
Co-authored-by: Lara Schmid <[email protected]>
jessiemongeon1
approved these changes
Jan 30, 2024
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing/making-proposals.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.