Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rangeBy() and rangeByInclusive() to Nat and Int modules #140

Merged
merged 19 commits into from
Feb 17, 2025

Conversation

rvanasa
Copy link
Collaborator

@rvanasa rvanasa commented Feb 10, 2025

Continuation of #124.

  • Rename step() to rangeBy() (we could perhaps use another function name)
  • Implement rangeByInclusive() for Nat and Int

We can add the fixed-size numeric modules in a future PR, since there is some ambiguity about which data type to use for the fixed-sized Nat* step size.

Copy link

github-actions bot commented Feb 10, 2025

No description provided.

@rvanasa rvanasa changed the base branch from main to update-tests February 11, 2025 00:06
Base automatically changed from update-tests to main February 11, 2025 10:35
@rvanasa rvanasa changed the title Add rangeWithStep() to numeric modules Add rangeBy() and rangeByInclusive() to numeric modules Feb 13, 2025
@rvanasa rvanasa changed the title Add rangeBy() and rangeByInclusive() to numeric modules Add rangeBy() and rangeByInclusive() to Nat and Int modules Feb 13, 2025
@rvanasa rvanasa marked this pull request as ready for review February 13, 2025 18:40
@rvanasa rvanasa requested a review from a team as a code owner February 13, 2025 18:40
Copy link
Contributor

@luc-blaeser luc-blaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@luc-blaeser luc-blaeser merged commit b1dfa78 into main Feb 17, 2025
6 checks passed
@luc-blaeser luc-blaeser deleted the range-with-step-continuation branch February 17, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants