Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing base library tests #116

Merged
merged 66 commits into from
Feb 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
711e14f
Update CI
rvanasa Jan 15, 2025
ce23ba3
Use fallback
rvanasa Jan 15, 2025
599584a
Add doc comments for existing module functions
rvanasa Jan 15, 2025
3ee3468
Add missing 'Int8' functions
rvanasa Jan 15, 2025
3fbad58
Update import
rvanasa Jan 15, 2025
dbd691c
Misc
rvanasa Jan 16, 2025
5f686b6
Fix compiler errors
rvanasa Jan 16, 2025
daf3b3d
Fix validation errors
rvanasa Jan 16, 2025
f6a0556
Generate lockfile to compare API with main branch
rvanasa Jan 16, 2025
de09de4
Setup API lockfile
rvanasa Jan 16, 2025
f037c88
Simplify lockfile
rvanasa Jan 16, 2025
bf81890
Check for API changes in CI
rvanasa Jan 16, 2025
f35052e
Adjust diff command
rvanasa Jan 16, 2025
b71c385
Adjust diff command again
rvanasa Jan 16, 2025
13d0eb8
Try changing API to see if diff works as expected
rvanasa Jan 16, 2025
1132844
Clarify error message
rvanasa Jan 16, 2025
71ff596
Misc
rvanasa Jan 16, 2025
2c2313e
Rollback arbitrary API change
rvanasa Jan 16, 2025
fa54722
Merge branch 'ci' into implement-existing
rvanasa Jan 16, 2025
285f7a7
Fix merge
rvanasa Jan 16, 2025
32a04fa
Update API lockfile
rvanasa Jan 16, 2025
8cc3400
Remove extraneous import
rvanasa Jan 16, 2025
71125a6
Adjust param names in 'Char'
rvanasa Jan 16, 2025
6b71fb8
Fix regex corner cases
rvanasa Jan 16, 2025
4396223
Merge branch 'ci' into implement-existing
rvanasa Jan 16, 2025
4b752d3
Update API lockfile
rvanasa Jan 16, 2025
ee817e5
Adjust to new API
rvanasa Jan 16, 2025
ae0c91f
Fix corner case
rvanasa Jan 16, 2025
d4fda89
Merge branch 'ci' into implement-existing
rvanasa Jan 16, 2025
d961e57
Update API lockfile
rvanasa Jan 16, 2025
63e2a09
Rename params for consistency
rvanasa Jan 16, 2025
4a83567
Update API lockfile
rvanasa Jan 16, 2025
00ab44e
Update 'Result' type bindings
rvanasa Jan 16, 2025
b004b93
Fix
rvanasa Jan 16, 2025
8f6221a
Fix compile errors
rvanasa Jan 16, 2025
054b518
Add doc comments for Queue
rvanasa Jan 16, 2025
e94a5d5
Update doc comments
rvanasa Jan 16, 2025
7cb6708
Add implementations
rvanasa Jan 17, 2025
088c7dc
Update doc comments
rvanasa Jan 17, 2025
edd7c0a
Add tests from original base library
rvanasa Jan 21, 2025
aa44081
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 21, 2025
88246b3
Progress
rvanasa Jan 23, 2025
3a46276
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 23, 2025
f957bd7
Progress
rvanasa Jan 23, 2025
0e296a9
Replace 'Iter.iterate()' with 'Iter.forEach()' and 'Iter.enumerate()'
rvanasa Jan 23, 2025
a82bb43
Update API lockfile
rvanasa Jan 23, 2025
d74564b
Split 'Option.iterate()' into 'Option.forOk()' and 'Option.forErr()'
rvanasa Jan 23, 2025
0e152f4
Update API lockfile
rvanasa Jan 23, 2025
5885682
Merge branch 'main' into iter-enumerate
rvanasa Jan 23, 2025
acbeeb8
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 23, 2025
9c41e4f
Progress
rvanasa Jan 24, 2025
1712ba9
Progress
rvanasa Jan 24, 2025
3a4b2f7
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 27, 2025
efe5ac6
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 27, 2025
df5238f
Update API lockfile
rvanasa Jan 27, 2025
1c304d2
Progress
rvanasa Jan 27, 2025
eb573e9
Fix merge
rvanasa Jan 27, 2025
100c4dd
Progress
rvanasa Jan 27, 2025
a3095e2
Temporarily skip 'Text' unit tests
rvanasa Jan 27, 2025
9ae5c46
Update API lockfile
rvanasa Jan 28, 2025
1794081
Merge branch 'main' into test-existing
rvanasa Jan 28, 2025
ae1bf1e
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 30, 2025
666029e
Fix merge
rvanasa Jan 30, 2025
55c5a00
Merge branch 'main' of https://github.com/dfinity/new-motoko-base int…
rvanasa Jan 31, 2025
0a52bdf
Update API lockfile
rvanasa Jan 31, 2025
608ec7a
Update API lockfile
rvanasa Feb 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify error message
rvanasa committed Jan 16, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 11328444494b4ff6b22e7e1dec1cb2c59da84306
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ jobs:
if [ -n "$DIFF" ]; then
echo "API changes:"
echo "$DIFF"
echo If this seems correct, please run the `npm run validate` command and then commit the output.
echo 'If this looks correct, please run the command `npm run validate` and commit the output.'
exit 1
fi