Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing base library tests #116

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Add existing base library tests #116

wants to merge 65 commits into from

Conversation

rvanasa
Copy link
Collaborator

@rvanasa rvanasa commented Jan 23, 2025

Resolves #91.

This PR includes most of the original base library unit tests with a few modifications (renaming fields, updating range() to use an exclusive bound, etc.). The goal is to eventually include a test coverage CI workflow so that we can ensure that all functions have corresponding unit tests.

Some of the tests currently have the extension *.test.skip.mo due to missing data structure implementations. I will address these in follow-up PRs.

@rvanasa rvanasa requested a review from a team as a code owner January 23, 2025 01:58
Copy link

github-actions bot commented Jan 23, 2025

✨ Documentation preview for 0a52bdf:

https://dfinity.github.io/new-motoko-base/pull/116 (source code)

@rvanasa rvanasa marked this pull request as draft January 23, 2025 01:58
@rvanasa rvanasa changed the base branch from main to iter-enumerate January 27, 2025 19:42
@rvanasa rvanasa marked this pull request as ready for review January 27, 2025 20:59
Base automatically changed from iter-enumerate to main January 28, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation: existing base library functions
1 participant