web container #253
web container #253
Conversation
src/examples.ts
Outdated
| @@ -8,7 +8,7 @@ export interface ExampleProject { | |||
|
|
|||
| const example = { | |||
| repo: "dfinity/examples", | |||
| branch: "master", | |||
| branch: "bump-agent-js", | |||
There was a problem hiding this comment.
Adding a comment here to set this back to the master branch after it's merged.
src/examples.ts
Outdated
| const json = JSON.parse(packageJson); | ||
| if (json.scripts) { | ||
| Object.entries(json.scripts).forEach(([key, value]) => { | ||
| if (typeof value === "string" && value.startsWith("dfx")) { |
There was a problem hiding this comment.
Seems okay for now, and perhaps we can find a more elegant way to do this in the future.
One possibility could be to create a simulated dfx command which always succeeds and prints an informational message to the console like "Skipped running command: `dfx generate my_canister`".
There was a problem hiding this comment.
Right, that's the first thing I tried. There is a PATH environment variable, but jsh doesn't seem to respect it. So we will have to call ./dfx instead of dfx. I haven't tried to pass PATH directly in spawn though.
| return; | ||
| } | ||
| const userAgent = navigator.userAgent.toLowerCase(); | ||
| // TODO: double check the browsers listed here indeed works |
There was a problem hiding this comment.
Maybe we could use one of these solutions?
There was a problem hiding this comment.
Interesting. It seems window.chrome is not very robust. Some versions of Edge has that, and some don't. The current solution is probably more reliable.
Co-authored-by: Ryan Vandersmith <[email protected]>
Co-authored-by: Ryan Vandersmith <[email protected]>
* create new canisters on demand; deploy stored wasm * fix * fix * fix * chore: Whitelist frontend canister hash from dfx version 0.24.1 (#265) Co-authored-by: adamspofford-dfinity <[email protected]> * fix * fix * fix cycle after expiration (#266) * fix * fix * fix --------- Co-authored-by: DFINITY bot <[email protected]> Co-authored-by: adamspofford-dfinity <[email protected]>
Workflow:
canister_id.jsonand.envfiles needed for frontend buildpackage.json, a selection of non-".mo" file will enable frontend buildnpm install,npm run buildnode upploadAsset.js <asset_canister> <dist_dir>Known limitations:
npm installin jsh. Normal deployment is fine. Safari support is only in TP.