Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically change installer origin when loading projects from various sources #193

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Sep 7, 2023

Updates the origin reported in installCode() in the following situations:

  • New, empty project (playground:new)
  • New project from an example (playground:example:{name})
  • Load from a tag (playground:tag:{tag})
  • Load from a Git repository (playground:git:{repo})
  • Load from an editor integration (playground:post:{origin})

This PR also includes some miscellaneous refactoring, mostly to improve front-end type checking.

@rvanasa rvanasa marked this pull request as draft September 7, 2023 18:56
@rvanasa rvanasa marked this pull request as ready for review September 7, 2023 19:22
@rvanasa rvanasa merged commit b86dd45 into add-origin Sep 7, 2023
3 checks passed
@rvanasa rvanasa deleted the ryan/add-origin branch September 7, 2023 20:49
chenyan-dfinity added a commit that referenced this pull request Sep 8, 2023
* add stats by origin

* fix

* fix

* frontend

* fix

* Dynamically change installer origin when loading projects from various sources (#193)

* Convert 'allowedOrigins' to TypeScript

* Add 'setOrigin' workplace reducer action

* Progress

* Refactor example projects to use example name in origin

* Misc

* Use URL origin in place of editor key for 'playground:post'

* Reintroduce details for 'tag' and 'git' origins

* Keep track of 'document.referrer' and 'window.opener'

* Misc

* change origin type to include array of tags

* fix

* add backend tags

---------

Co-authored-by: Ryan Vandersmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants