Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-canisters script when no arguments #2686

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix test-canisters script when no arguments #2686

merged 1 commit into from
Nov 6, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Nov 6, 2024 •
edited by github-actions bot
Loading

Motivation

The script test-canisters.sh didn't work when no arguments were passed.

Changes

Handle scenario when the arguments and filtered arguments are empty.

🟡 Some screens were changed

@lmuntaner lmuntaner marked this pull request as ready for review November 6, 2024 10:26
@lmuntaner lmuntaner requested a review from a team as a code owner November 6, 2024 10:26
@lmuntaner
Copy link
Collaborator Author

@sea-snake please review

sea-snake
sea-snake approved these changes Nov 6, 2024
View reviewed changes
Copy link

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lmuntaner lmuntaner added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 34df5ae Nov 6, 2024
67 checks passed
@lmuntaner lmuntaner deleted the lm-fix-test-canister-script branch November 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-snake sea-snake sea-snake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @sea-snake