Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

feat: body decoding #27

Merged
merged 8 commits into from
Mar 17, 2022
Merged

feat: body decoding #27

merged 8 commits into from
Mar 17, 2022

Conversation

3cL1p5e7
Copy link
Contributor

@3cL1p5e7 3cL1p5e7 commented Mar 4, 2022

Added gzip and deflate body decoding before certification validation.
Code separation from PR

@3cL1p5e7 3cL1p5e7 mentioned this pull request Mar 4, 2022
Open
@Daniel-Bloom-dfinity
Refactor: Some minor fixes
5258a23 
Use `const` instead of `static`
Change `decode_body` to be chunk-based.
Some minor style fixes
@Daniel-Bloom-dfinity
nit
dfcd968
@Daniel-Bloom-dfinity
clippy
7321942
@Daniel-Bloom-dfinity
Copy link
Contributor

Thank you for this! I made some minor changes (chunk-wise decoding instead of all at once). Otherwise this LGTM.

jplevyak
jplevyak reviewed Mar 8, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@Daniel-Bloom-dfinity Daniel-Bloom-dfinity merged commit 330deb1 into dfinity:main Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity Daniel-Bloom-dfinity approved these changes

@jplevyak jplevyak Awaiting requested review from jplevyak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3cL1p5e7 @Daniel-Bloom-dfinity @jplevyak