fix: [EXC-1831] Low Wasm memory hook will run once the canister's unfrozen if it was scheduled before freezing #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragoljub-duric
commented
Jan 15, 2025
|
An alternative approach was, that instead of always updating the hook status to |
dragoljub-duric
changed the title
berestovskyy
approved these changes
Jan 16, 2025
dragoljub-duric
deleted the
EXC-1831-if-canister-gets-frozen-immediately-after-the-hook-is-scheduled-for-execution-the-hook-will-run-once-the-canisters-unfrozen
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
… fixed (#3631) Problem: As previously observed by @berestovskyy #3455 (comment) it may happen that execution of low_wasm_memory hook is stopped when `wasm_memory_limit` < `used_wasm_memory`. Solution: If that happens, run the hook after the error is fixed if the hook condition remains satisfied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
@mraszyk noticed here that property:
”If the canister gets frozen immediately after the function is scheduled for execution, the function will run once the canister's unfrozen if the canister's wasm memory remains above the threshold t.”
is missing.
Solution:
When execution of the hook is stopped because of the freezing canister, add the hook again to the task queue.