Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert from 24.04 build container #2951

Merged
merged 4 commits into from
Dec 5, 2024
Merged

fix: Revert from 24.04 build container #2951

merged 4 commits into from
Dec 5, 2024

Conversation

Bownairo
Copy link
Member

@Bownairo Bownairo commented Dec 3, 2024

Revert changes from #1946 and #2858 until we can dynamically link to an older libraries for broader compatibility in distributed binaries.

@Bownairo
Revert "fix(IDX): libtinfo5-6.4 is no longer available in ubuntu so u…
e247008 
…se 6.3 (#2858)"

This reverts commit f06dfa4 excluding
container tags.
@Bownairo
Revert "feat: [NODE-1355] Upgrade build container to 24.04 (#1946)"
22e24a6 
This reverts commit 260f1cc excluding
container tags.
@github-actions github-actions bot added the fix label Dec 3, 2024
Updating container image to sha256:4fd13b47285e783c3a6f35aadd9559d097…
11e32b9 
…c0de162a1cf221ead66ab1598d5d45

Image tag: 7beeb6e69346fd10ff4421688aec841d072ac4f8c4c80d3b089d64aa280c0894
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Run URL: https://github.com/dfinity/ic/actions/runs/12144971553

New container image: sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
New container tag: 7beeb6e69346fd10ff4421688aec841d072ac4f8c4c80d3b089d64aa280c0894

@Bownairo
Copy link
Member Author

Bownairo commented Dec 3, 2024

Is there any way to skip //rs/tests/message_routing:queues_compatibility_test? The mainnet binary uses the new libc, so does not run in this container.

@Bownairo Bownairo added the @idx label Dec 4, 2024
@nmattia nmattia marked this pull request as ready for review December 5, 2024 10:03
@nmattia nmattia requested review from a team as code owners December 5, 2024 10:03
@nmattia nmattia merged commit df6e86c into master Dec 5, 2024
41 of 43 checks passed
@nmattia nmattia deleted the eero/revert-24.04-build branch December 5, 2024 10:32
@nmattia
Copy link
Contributor

nmattia commented Dec 5, 2024

Force merged as requested by @sasa-tomic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmu0 tmu0 tmu0 approved these changes

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
@finint fix @ic-owners-owners @idx @platform-operations @product-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bownairo @nmattia @basvandijk @tmu0