fix: EXC-1787: Fix scheduler AP divergence #2563
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
366
to
371
| let good_standing = canister.scheduler_state.accumulated_priority >= 0.into(); | ||
| if !has_aborted_or_paused_execution || !good_standing { | ||
| RoundSchedule::apply_priority_credit(canister); | ||
| } |
There was a problem hiding this comment.
Is this actually needed? It feels to me like the only required change is the one below (bundle negative AP DTS executions with non-DTS executions instead of with the other DTS executions).
There was a problem hiding this comment.
To treat canisters with long executions just like canisters with new executions we need also to charge them every round. But this change does not change much...
This reverts commit d880b8e.
berestovskyy
force-pushed
the
andriy/exc-1787-scheduler-divergence-debug
branch
from
6c25e97
to
ed66eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.