Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boundary): add inspect_message hook to canister #2554

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat(boundary): add inspect_message hook to canister #2554

merged 3 commits into from
Nov 13, 2024
+75 −18

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Nov 11, 2024 •
edited
Loading

With this inspect_message() hook, the canister rejects ingress messages in the pre-consensus phase if:

  • Called method is neither one of the update canister methods nor get_config replicated query
  • Method's authorization policy is not fulfilled

@github-actions github-actions bot added the feat label Nov 11, 2024
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review November 11, 2024 15:52
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner November 11, 2024 15:52
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner November 11, 2024 20:30
@github-actions github-actions bot added the @idx label Nov 11, 2024
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-canister-inspect-message branch 2 times, most recently from b702ef3 to 5be7af5 Compare November 11, 2024 20:35
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-canister-inspect-message branch from 5be7af5 to 223fa1f Compare November 11, 2024 20:54
@nikolay-komarevskiy nikolay-komarevskiy added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit fdc387b Nov 13, 2024
26 checks passed
@nikolay-komarevskiy nikolay-komarevskiy deleted the komarevskiy/rate-limit-canister-inspect-message branch November 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraszyk mraszyk mraszyk left review comments

@r-birkner r-birkner r-birkner approved these changes

Assignees
No one assigned
Labels
@boundary-node feat @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolay-komarevskiy @mraszyk @r-birkner