Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for targetting arbitrary IC network on the cli #302

Merged
merged 17 commits into from
Apr 8, 2024
Merged

feat: Support for targetting arbitrary IC network on the cli #302

merged 17 commits into from
Apr 8, 2024

Conversation

sasa-tomic
Copy link
Member

@sasa-tomic sasa-tomic commented Apr 5, 2024 •
edited
Loading

The entire DRE stack (CLI, backend, etc.) should now work without issues on mainnet, staging, or any testnets, without any clutches or hacks.

Example use:

Use default NNS URLs

dre --network staging <operation>

Force-override a custom NNS URLs for a known network

dre --network staging --nns-url http://[2600:2c01:21:0:5000:beff:fecb:ff53]:8080 get topology

Testnets do not have known (preconfigured) NNS URLs

dre --network medium01 --nns-url <url> <operation>

@sasa-tomic sasa-tomic marked this pull request as ready for review April 5, 2024 17:38
@sasa-tomic sasa-tomic requested a review from a team as a code owner April 5, 2024 17:38
@sasa-tomic sasa-tomic changed the title feat: Support for configuring arbitrary target network on the cli feat: Support for targetting arbitrary network on the cli Apr 5, 2024
@sasa-tomic sasa-tomic changed the title feat: Support for targetting arbitrary network on the cli feat: Support for targetting arbitrary IC network on the cli Apr 5, 2024
NikolaMilosa
NikolaMilosa approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sasa-tomic sasa-tomic added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit d1ac15b Apr 8, 2024
6 checks passed
@sasa-tomic sasa-tomic deleted the sat-dre-network-configurable branch April 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasa-tomic @NikolaMilosa