Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a runbook link to guestos label missing error message #1038

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add a runbook link to guestos label missing error message #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion release-controller/release_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,9 @@ def is_guestos_change(ic_repo: GitRepo, commit: str) -> bool:
"""Check if GuestOS changed for the commit by querying git notes populated by commit annotator."""
changed = ic_repo.get_note(GUESTOS_CHANGED_NOTES_NAMESPACE, commit)
if not changed:
raise ValueError(f"Could not find targets for commit {commit}")
raise ValueError(
f"Could not find GuestOS label for commit {commit}. Check out commit annotator logs and runbook: https://dfinity.github.io/dre/release.html#missing-guestos-label."
)
changed = changed.strip()
if changed == "True":
return True
Expand Down
Loading