feat: get_chunks_info query method #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cL1p5e7
changed the title
src/ic-certified-assets/src/lib.rs
Outdated
| #[derive(Clone, Debug, CandidType, Deserialize)] | ||
| struct ChunkInfo { | ||
| chunk_id: ChunkId, | ||
| total_length: Nat, |
There was a problem hiding this comment.
I would rename this maybe to chunk_length
jplevyak
reviewed
Feb 17, 2022
| @@ -203,6 +203,18 @@ struct HttpRequest { | |||
| body: ByteBuf, | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, CandidType, Deserialize)] | |||
| struct ChunkInfo { | |||
There was a problem hiding this comment.
We want to have certification of these results and to add certification for the get_chunk call. I don't know if we need to do that in this PR though.
There was a problem hiding this comment.
@jplevyak
yes, most likely it is better to make a separate PR.
I am currently working on my own certified-assets-based chunk certification solution. If I succeed, then I will definitely share them in the PR format in order to at least discuss the solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to know chunks info of any asset for developing streaming strategy on client
Linked PR