Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fix #469

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Misc fix #469

merged 6 commits into from
Sep 27, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Sep 27, 2023

  • Fix merge_init_types and instantiate_candid when the main actor refers to a variable
  • Rust codegen: Add pub for struct fields.
  • impl CandidType for std::cmp::Reverse
  • Candid UI: draw flamegraph for upgrade

@github-actions
Copy link

Benchmark for 1d20382

Click to view benchmark
Test Base PR %
Blob/&str 298.8±158.31µs 257.7±79.76µs -13.76%
Blob/ByteBuf 226.6±63.69µs 225.2±54.17µs -0.62%
Blob/Bytes 167.0±87.97µs 161.8±58.99µs -3.11%
Blob/String 366.2±157.66µs 358.6±164.80µs -2.08%
Collections/vec (text, nat) 81.5±3.81ms 76.5±4.39ms -6.13%
Collections/vec int 37.8±1.44ms 34.4±1.51ms -8.99%
Collections/vec int64 21.2±1.25ms 19.6±1.18ms -7.55%
Collections/vec nat8 15.9±0.79ms 15.3±0.59ms -3.77%
option list/1024 1657.5±63.07µs 1592.1±72.98µs -3.95%
profiles/1024 3.1±0.11ms 3.0±0.13ms -3.23%
variant list/1024 1293.6±70.17µs 1221.5±61.10µs -5.57%

@github-actions
Copy link

Benchmark for c761db1

Click to view benchmark
Test Base PR %
Blob/&str 252.0±67.64µs 244.9±69.76µs -2.82%
Blob/ByteBuf 173.1±42.69µs 172.6±42.31µs -0.29%
Blob/Bytes 124.2±40.38µs 126.0±41.55µs +1.45%
Blob/String 327.9±149.51µs 319.4±149.28µs -2.59%
Collections/vec (text, nat) 72.5±1.14ms 72.8±1.52ms +0.41%
Collections/vec int 33.2±0.11ms 33.7±0.19ms +1.51%
Collections/vec int64 19.6±0.32ms 20.3±0.29ms +3.57%
Collections/vec nat8 14.4±0.05ms 14.5±0.05ms +0.69%
option list/1024 1376.4±2.19µs 1380.6±3.37µs +0.31%
profiles/1024 2.7±0.01ms 2.7±0.04ms 0.00%
variant list/1024 1133.5±1.83µs 1139.2±4.37µs +0.50%

@github-actions
Copy link

Benchmark for b225ba9

Click to view benchmark
Test Base PR %
Blob/&str 237.3±71.05µs 244.8±70.10µs +3.16%
Blob/ByteBuf 155.3±48.08µs 155.7±47.33µs +0.26%
Blob/Bytes 114.0±44.30µs 112.4±43.51µs -1.40%
Blob/String 307.7±150.20µs 316.5±150.34µs +2.86%
Collections/vec (text, nat) 69.4±0.85ms 69.7±1.12ms +0.43%
Collections/vec int 32.9±0.17ms 32.4±0.09ms -1.52%
Collections/vec int64 18.7±0.31ms 19.1±0.30ms +2.14%
Collections/vec nat8 14.3±0.03ms 14.3±0.03ms 0.00%
option list/1024 1386.1±6.89µs 1384.6±10.43µs -0.11%
profiles/1024 2.6±0.01ms 2.7±0.00ms +3.85%
variant list/1024 1130.4±7.58µs 1131.6±6.98µs +0.11%

@github-actions
Copy link

Benchmark for 226d33f

Click to view benchmark
Test Base PR %
Blob/&str 242.6±68.51µs 257.5±68.15µs +6.14%
Blob/ByteBuf 170.2±42.29µs 167.4±42.84µs -1.65%
Blob/Bytes 127.4±40.95µs 128.8±42.12µs +1.10%
Blob/String 325.5±149.37µs 336.5±147.07µs +3.38%
Collections/vec (text, nat) 71.2±1.11ms 71.9±1.34ms +0.98%
Collections/vec int 33.0±0.14ms 32.8±0.08ms -0.61%
Collections/vec int64 19.1±0.25ms 19.1±0.16ms 0.00%
Collections/vec nat8 14.3±0.03ms 14.4±0.03ms +0.70%
option list/1024 1391.3±29.47µs 1379.7±3.29µs -0.83%
profiles/1024 2.6±0.01ms 2.7±0.01ms +3.85%
variant list/1024 1135.4±1.72µs 1125.3±2.32µs -0.89%

@chenyan-dfinity chenyan-dfinity merged commit 3033772 into master Sep 27, 2023
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the misc-fix branch September 27, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants