Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pins nanoid dev dependency version to override warning #960

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Dec 11, 2024

also removes rollup pin which was added a while ago for similar reasons and is no longer needed

@krpeacock krpeacock requested a review from a team as a code owner December 11, 2024 22:38
lwshang
lwshang previously approved these changes Dec 11, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 72.09 KB (-17.39% 🔽)
@dfinity/candid 11.65 KB (-14.22% 🔽)
@dfinity/principal 4.16 KB (-16.3% 🔽)
@dfinity/auth-client 50.09 KB (-17.89% 🔽)
@dfinity/assets 67.77 KB (-17.4% 🔽)
@dfinity/identity 47.74 KB (-17.91% 🔽)
@dfinity/identity-secp256k1 106.18 KB (-19.78% 🔽)

@krpeacock krpeacock requested a review from lwshang December 11, 2024 23:07
@krpeacock krpeacock enabled auto-merge (squash) December 11, 2024 23:09
@krpeacock
Copy link
Contributor Author

Note - the size limit seems to have decreased a lot by updating the esbuild version! Unrelated to code changes, but end users will probably benefit from newer versions of tools that depend on it

@krpeacock krpeacock merged commit d1644db into main Dec 11, 2024
16 checks passed
@krpeacock krpeacock deleted the kai/nanoid-fix branch December 11, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants