Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exports polling utilities from @dfinity/agent #921

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Sep 6, 2024

Description

Noted by @peterpeterparker - the agent doesn't export the utilities out of the polling submodule.

At the same time, I've set the default polling strategy as an actual default, and the argument can now be omitted

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner September 6, 2024 16:53
Copy link
Contributor

github-actions bot commented Sep 6, 2024

size-limit report 📦

Path Size
@dfinity/agent 85.96 KB (+0.01% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.36 KB (0%)
@dfinity/assets 80.98 KB (+0.01% 🔺)
@dfinity/identity 57.56 KB (0%)
@dfinity/identity-secp256k1 131.14 KB (+0.11% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) September 9, 2024 17:35
@krpeacock krpeacock merged commit 7e992e3 into main Sep 9, 2024
16 checks passed
@krpeacock krpeacock deleted the kai/export-polling branch September 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants