-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor to remove nonce from queries #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krpeacock
changed the title
Kyle/sdk 1258 remove nonce queries
feat: refactor to remove nonce from queries
Oct 31, 2023
size-limit report 📦
|
Thanks. LGTM! |
4 tasks
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Nov 1, 2023
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replaces disableNonce feature with useQueryNonces. Going forward, calls will use nonces, but queries and readstate calls will not. Queries and readsatate calls will use nonces if
useQueryNonces
is set to true.Fixes # (issue)
How Has This Been Tested?
Removes the nonceless e2e tests as they are no longer applicable
Checklist: