Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICRC-37 language fixes #54

Merged
merged 1 commit into from
Feb 1, 2024
Merged

ICRC-37 language fixes #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ICRCs/ICRC-37/ICRC-37.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ The `created_at_time` parameter indicates the time (as nanoseconds since the UNI
```candid "Type definitions" +=
type ApprovalInfo = {
spender : Account; // Approval is given to an ICRC Account
from_subaccount : opt blob; // the subaccount the token can be transferred out from with the approval
from_subaccount : opt blob; // The subaccount the token can be transferred out from with the approval
expires_at : opt nat64;
memo : opt blob;
created_at_time : nat64;
Expand Down Expand Up @@ -202,7 +202,7 @@ type RevokeTokenApprovalArg = record {
};

type RevokeTokenApprovalResponse = variant {
Ok : nat; // Transaction indices for successful approval revocation
Ok : nat; // Transaction index for successful approval revocation
Err : RevokeTokenApprovalError;
};

Expand Down Expand Up @@ -247,7 +247,7 @@ type RevokeCollectionApprovalArg = record {
};

type RevokeCollectionApprovalResult = variant {
Ok : nat; // Transaction index for successful revocation
Ok : nat; // Transaction index for successful approval revocation
Err : RevokeCollectionApprovalError;
};

Expand Down Expand Up @@ -337,11 +337,10 @@ Batch transfers are not atomic by default, i.e., a user SHOULD not assume that e

```candid "Type definitions" +=
TransferFromArg = record {
spender_subaccount: opt blob; // the subaccount of the caller (used to identify the spender)
spender_subaccount: opt blob; // The subaccount of the caller (used to identify the spender)
from : Account;
to : Account;
token_id : nat;
// type: leave open for now
memo : opt blob;
created_at_time : opt nat64;
};
Expand Down
Loading