Skip to content

Commit

Permalink
ICRC-37 minor fix
Browse files Browse the repository at this point in the history
  • Loading branch information
dietersommer committed Feb 1, 2024
1 parent 1bfe121 commit 1ed8287
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions ICRCs/ICRC-37/ICRC-37.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ type ApprovalInfo = {
expires_at : opt nat64;
memo : opt blob;
created_at_time : nat64;
}
};
type ApproveTokenArg = record {
token_id : nat;
Expand All @@ -106,7 +106,7 @@ type ApproveTokenArg = record {
type ApproveTokenResult = variant {
Ok : nat; // Transaction index for successful approval
Err : ApproveTokenError;
}
};
type ApproveTokenError = variant {
InvalidSpender;
Expand Down Expand Up @@ -148,8 +148,6 @@ To ensure proper semantics, collection-level approvals MUST be managed by the le

See the [#icrc37_approve_tokens](#icrc37_approve_tokens) for the `ApprovalInfo` type.

// FIX Should we use ApproveCollectionArg = ApprovalInfo?

```candid "Type definitions" +=
type ApproveCollectionArg = record {
approval_info : ApprovalInfo;
Expand Down Expand Up @@ -206,7 +204,7 @@ type RevokeTokenApprovalArg = record {
type RevokeTokenApprovalResponse = variant {
Ok : nat; // Transaction indices for successful approval revocation
Err : RevokeTokenApprovalError;
}
};
type RevokeTokenApprovalError = variant {
ApprovalDoesNotExist;
Expand Down

0 comments on commit 1ed8287

Please sign in to comment.