Improve support feedback tab #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly becuase of the if loops added documentation and testing to the function
…so it matches the request's needs better. changed the documentation and the tests to relfect this but needs more work
…ent to support_panel still need to add more tests, fix the checks and update documentation
added more examples for how to use the functions updated the documentation and testing
updated documentation and testing
made html_paragraph_tags have heading as null to allow flexible use and checks in support_panel still need to add comments to the code
…that everything shows up as intended updated documentation
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Why are these changes being made?
Users wanted more flexibility on how the support panel looks.
Detailed description of changes
Details for extra arguments in support_panel():
html_paragraph_tags() supports with the extra arguments above by generating tags using shiny::tagList() and it generated a heading(optional) and a body (paragraph).
Changed a test in test-support-panel (line 175). This is because I put another shiny::tags$div() around the if statement for the feedback section if there no extra text. This changes the position of the title in the output for the test on that line even though the outputs are as expected.
Issue ticket number/s and link
54