Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial data clean-up for ancillary files #90

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented May 23, 2024

Pull request overview

I've added the ancillary files that aren't needed by the dashboard to .gitignore so that they don't bloat the repo.

Whilst I've been looking through the repo, I've also:

  • Adjusted the deploy script to try and sidestep some known recent issues
  • Changed the cookie handling to use the standard dfeshiny module

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

@rmbielby rmbielby self-assigned this May 23, 2024
@rmbielby rmbielby requested a review from t-surtees May 23, 2024 13:21
@rmbielby rmbielby changed the base branch from main to 30MayLiveData May 23, 2024 13:22
@rmbielby rmbielby merged commit c107ca2 into 30MayLiveData May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants