Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-term sentence and response rate fix #84

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

GemmaSelby29
Copy link
Contributor

@GemmaSelby29 GemmaSelby29 commented Mar 21, 2024

Pull request overview

Removing half-term sentence which is no longer relevant and making % schools reporting reactive

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Sentence on homepage still says response rate of 60%, lower than normal due to half term

What is the new behaviour?

Removed half term wording and percentage updated to 90%, also now as a result of calculation rather than a manual update

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@GemmaSelby29 GemmaSelby29 merged commit 6a0cd3c into main Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants